I thought Johnny Weir did a very creditable job with his commentary and analysis. He was clear spoken, fair, and eloquent. He has such a lively personality and he keeps the broadcast interesting. I him in this role! Go Johnny, be good!
However, I did feel that Terry Gannon was questioning Johnny too much during the skaters' programs and it was a little distracting trying to hear the music. I think they should try to stick with sparse comments during the performance and then maybe address more thought provoking questions after the program ends when the skater is taking their bows, leaving the ice, and receiving their marks in the kiss and cry.
All in all though, I found Johnny and Terry to be a pleasant team.